Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates a Template for new PRs #3965

Merged
merged 10 commits into from
Feb 14, 2025
Merged

Creates a Template for new PRs #3965

merged 10 commits into from
Feb 14, 2025

Conversation

varodrig
Copy link
Contributor

@varodrig varodrig commented Jan 19, 2025 •
edited
Loading

Checklist:

Description of your changes:
This PR creates a new template for new PRs similar to this description. This will help the community to understand quickly what a PR will be enhancing or resolving in the website. Additionally by linking the issue it helps reduce the issues that are not closed even thought were resolved.

Issue

Closes: #3936

Labels

/area other

@google-oss-prow Google OSS Prow
Copy link

@varodrig: The label(s) area/other cannot be applied, because the repository doesn't have them.

In response to this:

Checklist:

Description of your changes:
This PR creates a new template for new PRs similar to this description. This will help the community to understand quickly what a PR will be enhancing or resolving in the website. Additionally by linking the issue it helps reduce the issues that are not closed even thought were resolved.

Issue

Closes: #3936

Labels

/area other

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varodrig
Copy link
Contributor Author

/area other

@google-oss-prow Google OSS Prow
Copy link

@varodrig: The label(s) area/other cannot be applied, because the repository doesn't have them.

In response to this:

/area other

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@varodrig
Copy link
Contributor Author

varodrig commented Jan 19, 2025 •
edited
Loading

@andreyvelich and @hbelmiro to review thank you and anyone else from the community who wants to provide feedback.
Also we need to create new labels before merging. Can you help with this?
Created an issue
#3967

@varodrig
Copy link
Contributor Author

/hold

@varodrig
Copy link
Contributor Author

cc @kubeflow/kubeflow-steering-committee @kubeflow/wg-training-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-manifests-leads @kubeflow/release-team @kubeflow/wg-data-leads @kubeflow/wg-deployment-leads

hbelmiro
hbelmiro reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I'm not allowed to modify labels @varodrig.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 20, 2025
@varodrig
Copy link
Contributor Author

/area website

@google-oss-prow google-oss-prow bot added the area/website AREA: Website Styles/Hosting/Serving label Jan 31, 2025
@varodrig
update pr with labels
606c6bd 
Signed-off-by: varodrig <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Jan 31, 2025
@varodrig
Copy link
Contributor Author

/hold cancel

@varodrig
removing old label
47f718c 
Signed-off-by: varodrig <[email protected]>
hbelmiro
hbelmiro reviewed Feb 1, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 1, 2025
@varodrig
Copy link
Contributor Author

varodrig commented Feb 5, 2025

Since this is affecting all Working groups, please review

@hbelmiro @thesuperzapper @rimolive @tarilabs @franciscojavierarceo

andreyvelich
andreyvelich reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varodrig Would it be better to ask users to open website-related issues in the corresponding GitHub repositories for each project?

From our past experience, WG leads tend to triage issues more effectively in their own repos than in kubeflow/website.
cc @jbottum

Sorry this message relates to: #3964

@google-oss-prow google-oss-prow bot removed the lgtm label Feb 7, 2025
hbelmiro
hbelmiro reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 7, 2025
@juliusvonkohout
Copy link
Member

I am in favor of merging this as soon as possible to have the basic functionality and then iterating on it in follow-up PRs.

@andreyvelich
Copy link
Member

@varodrig Can you create tracking issue for the GitHub actions automation so we can find contribution who can work on it?

@varodrig varodrig mentioned this pull request Feb 14, 2025
Open
andreyvelich
andreyvelich reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this effort @varodrig!
/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8916531 into kubeflow:master Feb 14, 2025
6 checks passed
@varodrig varodrig deleted the pull branch February 14, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesuperzapper thesuperzapper thesuperzapper left review comments

@hbelmiro hbelmiro hbelmiro left review comments

@andreyvelich andreyvelich andreyvelich left review comments

@jbottum jbottum Awaiting requested review from jbottum

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@hbelmiro hbelmiro

Labels
approved area/website AREA: Website Styles/Hosting/Serving lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a PR template for the website
5 participants
@varodrig @juliusvonkohout @andreyvelich @thesuperzapper @hbelmiro